View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0020690 | mantisbt | bugtracker | public | 2016-03-11 14:58 | 2023-10-15 04:43 |
Reporter | cproensa | Assigned To | dregad | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | 1.3.0-rc.2 | ||||
Target Version | 2.24.4 | Fixed in Version | 2.24.4 | ||
Summary | 0020690: inconsistent UI for view bugnote revision | ||||
Description | Currently, when a bugnote has been modified, a link with access to "view revisions" is showed:
However, if clicked through, only users with "private_bugnote_threshold" access can view those revisions Some inconsistencies:
| ||||
Tags | No tags attached. | ||||
So if I understand correctly, you're saying we should have a specific config threshold driving who can view revisions ? |
|
Not necessariliy. My point is: Another point is: |
|
I think that creating a new config is the only way to make this consistent, because relying on private_bugnote_threshold does not really make sense for bug-level revisions. |
|
Design decision: users can always see the revisions for issues and bugnotes they reported, regardless of the new config's value (i.e. this setting currently does not allow to entirely "turn off" revisions) |
|
MantisBT: master c9a8aca2 2020-12-06 02:27 Details Diff |
New config $g_bug_revision_view_threshold Access level required to view bug history revisions. Note that users can always see the revisions for issues and bugnotes they reported, regardless of the new config's value. Two new Access API functions, access_can_view_bug_revisions() and access_can_view_bugnote_revisions(), can be used to check whether user has required access level. Fixes 0020690 |
Affected Issues 0020690 |
|
mod - config_defaults_inc.php | Diff File | ||
mod - core/access_api.php | Diff File | ||
MantisBT: master 57e9b01a 2020-12-06 02:59 Details Diff |
Hide 'View Revisions' if user has no access Do not display the 'View Revisions' link to the user if they are not allowed to see it, both when displaying bugnotes and in bug history. Added $p_bug_id parameter to history_localize_item() function, it is needed to call access_can_view_revisions(). Adapted mci_issue_get_history() and email_format_bug_message() to use the new function signature. Fixes 0020690 |
Affected Issues 0020690 |
|
mod - api/soap/mc_issue_api.php | Diff File | ||
mod - bugnote_view_inc.php | Diff File | ||
mod - core/email_api.php | Diff File | ||
mod - core/history_api.php | Diff File | ||
MantisBT: master e6365041 2020-12-14 07:38 Details Diff |
Documentation for bug revisions Added new $g_bug_revision_view_threshold config to Admin Guide's Bug History section, as well as $g_bug_revision_drop_threshold which was previously not documented. Issue 0020690 |
Affected Issues 0020690 |
|
mod - config_defaults_inc.php | Diff File | ||
mod - docbook/Admin_Guide/en-US/config/bughistory.xml | Diff File |