View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0023694 | mantisbt | plug-ins | public | 2017-12-04 05:47 | 2019-07-06 08:13 |
Reporter | Ruzhelovich Vladimir | Assigned To | dregad | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | 2.8.0 | OS | Ubuntu | OS Version | 16.04.3 LTS |
Product Version | 2.0.0 | ||||
Target Version | 2.21.0 | Fixed in Version | 2.21.0 | ||
Summary | 0023694: View Issue page menu links from EVENT MENU_ISSUE event are wrapped with "[", "]" characters | ||||
Description | Wrong show the menu of plugins for EVENT MENU_ISSUE event. There are "[","]" characters in this menu. | ||||
Steps To Reproduce |
| ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Perhaps the problem is in this part ("bug_view_inc.php"): |
|
For english: |
|
A PR was submitted to fix this issue - https://github.com/mantisbt/mantisbt/pull/1502 This behavior is a leftover from Mantis 1.x where links were shown as Note: the problem only occurs when the plugin's event hook returns cooked links, so IMO the proper way to fix this would be to deprecate print_bracket_link_prepared() function, update event documentation to reflect that it should return an array like |
|
Alternate PR https://github.com/mantisbt/mantisbt/pull/1503 addresses the issue by obsoleting print_bracket_link_prepared() function. As mentioned earlier, plugins should be updated to return an associative array with the link's label as key and the link target as value, e.g. |
|
MantisBT: master 4714c1ac 2019-04-12 12:59 Details Diff |
Obsolete print_bracket_link_prepared() This function was used in MantisBT 1.x to display links surrounded by square brackets for menus. With MantisBT Modern UI, it has been replaced with CSS styling, to display the links as buttons. One use case was not properly migrated, when displaying links on View Issues Page (processing the EVENT_MENU_ISSUE hook). The problem cannot be fixed properly within MantisBT code, it requires an update of the Plugin's hook (returning an array of `label => link` pairs instead of cooked links). Consequently, the function has been marked as obsolete so that a warning is displayed, to inform plugin developers that they should update their code. Fixes 0023694 |
Affected Issues 0023694 |
|
mod - core/print_api.php | Diff File | ||
mod - docbook/Developers_Guide/en-US/Events_Reference_Output.xml | Diff File |