View Issue Details

IDProjectCategoryView StatusLast Update
0027574mantisbtuipublic2021-03-17 11:25
Reporterdregad Assigned Todregad  
PrioritylowSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Target Version2.25.0Fixed in Version2.25.0 
Summary0027574: Manage users edit page: inconsistent spacing between sections
Description

The spacing between the Edit User and Add user to project sections is not the same as between Add user to project and Account Preferences.

TagsNo tags attached.

Relationships

related to 0028080 resolveddregad Unsightly vertical offset of the "Update Prefs" and "Reset Prefs" buttons. 

Activities

atrol

atrol

2021-01-02 12:50

developer   ~0064913

grafik.png (15,309 bytes)   
grafik.png (15,309 bytes)   
grafik-2.png (15,646 bytes)   
grafik-2.png (15,646 bytes)   
atrol

atrol

2021-01-02 12:51

developer   ~0064914

grafik-3.png (11,828 bytes)   
grafik-3.png (11,828 bytes)   
atrol

atrol

2021-01-02 12:54

developer   ~0064915

There is a vertical shift when visiting the Preferences tab.
grafik.png is based on master-2.24 branch

dregad

dregad

2021-01-03 18:03

developer   ~0064919

Thanks for the feedback, and sorry this regression escaped my attention when I tested this - guess I didn't think of comparing with sibling user profile pages.

Related Changesets

MantisBT: master f65b0cae

2020-11-21 18:19:08

dregad

Details Diff
Fix markup in account_prefs_inc.php

The sequence of wrapping divs was different from the usual layout,
causing inconsistent spacing when the account preferences section
was displayed on manage_user_edit_page.php.

edit_account_prefs() no longer prints the outer div, letting the parent
page take care of it.

Fixes 0027574
Affected Issues
0027574, 0028080
mod - account_prefs_inc.php Diff File
mod - account_prefs_page.php Diff File
mod - manage_user_edit_page.php Diff File

MantisBT: master 63a794e9

2021-01-03 17:47:56

dregad

Details Diff
Fix markup in account_prefs_inc.php (take 2)

Commit f65b0cae3b9d4db820d15695e69e797dcdf98bd3 introduced a regression
in the user preferences on account_prefs_page.php.

This fixes the problem, by printing the wrapping div and spacer within
the edit_account_prefs() function again, but only when the Accounts menu
is shown (p_accounts_menu == true).

Fixes 0027574
Affected Issues
0027574
mod - account_prefs_inc.php Diff File
mod - account_prefs_page.php Diff File